remove string_view STL dependency #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjp41
reviewed
Dec 11, 2024
|
The CI failures are due to macos-12 being obsolete. We should probably update the images |
|
I've just pushed a PR to move the CI forward to newer versions. Hopefully will be smooth. |
|
Rebasing should fix the CI. |
mjp41
reviewed
Dec 11, 2024
| @@ -159,9 +159,7 @@ namespace snmalloc | |||
| * The following are supported as arguments: | |||
| * | |||
| * - Characters (`char`), printed verbatim. | |||
| * - Strings (anything convertible to `std::string_view`), typically string | |||
There was a problem hiding this comment.
As we've lost the other types that can flow into this, I am left wondering if we actually use this append function?
There was a problem hiding this comment.
As I guess I'm wondering if we should inline the functionality into append?
There was a problem hiding this comment.
Sorry, was busy on other stuffs. Inling should work except the two definitions will run into ambiguity.
SchrodingerZhu
force-pushed
the
standalone-string-view
branch
7 times, most recently
from
d3e042e to
a322264
Compare
SchrodingerZhu
force-pushed
the
standalone-string-view
branch
from
a322264 to
21e2570
Compare
mjp41
approved these changes
Dec 15, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.