Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

remove extra puts definitions #731

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

SchrodingerZhu
Copy link
Collaborator

@SchrodingerZhu SchrodingerZhu commented Jan 16, 2025

Use the definition from stdio.h directly. Manually defining such symbol may lead to mismatched exception spec.

/code/snmalloc/src/snmalloc/backend_helpers/../mem/../ds/../pal/pal_linux.h:22:16: error: 'puts' is missing exception specification 'throw()'
   22 | extern "C" int puts(const char* str);
      |                ^
      |                                      throw()
/code/snmalloc/src/snmalloc/backend_helpers/../mem/../ds/../pal/pal_posix.h:26:16: note: previous declaration is here
   26 | extern "C" int puts(const char* str);
      |                ^
1 error generated.
ninja: build stopped: subcommand failed.

@mjp41 mjp41 enabled auto-merge (squash) January 16, 2025 10:31
@mjp41 mjp41 merged commit 229c6d0 into microsoft:main Jan 16, 2025
62 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants