Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix for issue that decimal number are exported to excel as strings #1425

Merged
merged 2 commits into from
Mar 14, 2022

Conversation

alanrenmsft
Copy link
Contributor

In previous milestone, we fixed the issue that long but valid sql decimal can't be displayed in ADS (failed with conversion overflow), but we don't have special handler for those 2 types in the export to excel handler, as a result, the decimal values are being treated as strings.

microsoft/azuredatastudio#18615

Copy link
Contributor

@Charles-Gagnon Charles-Gagnon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you gone through all the other types and verified that they haven't changed how they're being exported either?

@alanrenmsft
Copy link
Contributor Author

Have you gone through all the other types and verified that they haven't changed how they're being exported either?

yes

@alanrenmsft alanrenmsft merged commit cc5cb40 into main Mar 14, 2022
@alanrenmsft alanrenmsft deleted the alanren/fix-export-to-excel-issue branch March 14, 2022 18:28
alanrenmsft added a commit that referenced this pull request Mar 14, 2022
…1425)

* fix export to excel issue with decimals

* add comment
alanrenmsft added a commit that referenced this pull request Mar 14, 2022
* handle UDT type (#1424)

* fix for issue that decimal number are exported to excel as strings (#1425)

* fix export to excel issue with decimals

* add comment
nofield pushed a commit that referenced this pull request Jul 19, 2022
…1425)

* fix export to excel issue with decimals

* add comment
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants