Implement all the arithmetic Scatter and ResourceScatter operators #121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstoecker
approved these changes
Dec 14, 2020
| @@ -304,3 +304,57 @@ const DML_BUFFER_BINDING* DmlKernel::GetPersistentResourceBinding() const { | |||
| } | |||
|
|
|||
| } // namespace tensorflow | |||
|
|
|||
| namespace dml { | |||
| DML_SCALAR_UNION ScalarTensor(double value, DML_TENSOR_DATA_TYPE data_type) { | |||
There was a problem hiding this comment.
nit: rename helper function to ScalarUnion since this doesn't return a tensor
| scalar.UInt64 = static_cast<uint64_t>(value); | ||
| break; | ||
|
|
||
| case DML_TENSOR_DATA_TYPE_FLOAT32: |
There was a problem hiding this comment.
Add DML_TENSOR_DATA_TYPE_FLOAT16?
| // | ||
| // TODO: ScatterElements (DML_SCATTER_ELEMENTS_OPERATOR_DESC) | ||
| // | ||
| inline Expression ScatterElements( |
There was a problem hiding this comment.
This reminds me that we should transition to the copy of DirectMLX.h in the DirectML github repo. I created bug 31071585 for this. In the meantime, make sure to port this change over to GitHub.
jstoecker
pushed a commit
that referenced
this pull request
Dec 15, 2020
jstoecker
added a commit
that referenced
this pull request
Dec 15, 2020
Merges some of the recent changes from the directml branch: * Use compute queue for AMD devices (#102) * Register List Kernels for DML (#95) * Update DirectMLX to latest (#104) * Remove extra rows from test email (#106) * Fix DML's Select kernel for int64 (#113) * Fix list kernels and tensor array ops registration (#114) * Simplify CI scripts (#112) * Fix StridedSlice's input size coalescing (#115) * Disable int64 image test (#116) * Fix network share copy path (#117) * Pipeline should continue if a test job fails (#118) * Switch network share path to use build number instead of build ID * Add missing HostMemory int32 registrations for _Arg and _RetVal (#122) * Implement all the arithmetic Scatter and ResourceScatter operators (#121) * Register emulated kernel implementations for RandomStandardNormal and TruncatedNormal (#120)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arithmetic Scatter and ResourceScatter operators are used quite a lot in the TensorFlow python tests, so they create a lot of false positive failures. Implementing these ups gets rid of about 50% of the failures and should improve performance on some models that we track.