Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Revert "Dedup command history by default (#17852)" #18229

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

lhecker
Copy link
Member

@lhecker lhecker commented Nov 21, 2024

This reverts commit 5fdfd51,
because 3 people complained about this change VS 1 person
requesting the change to be made in the first place.

Closes #18138
Reopens #17797 for discussion

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-CookedRead The cmd.exe COOKED_READ handling Priority-3 A description (P3) Product-Conhost For issues in the Console codebase labels Nov 21, 2024
@DHowett
Copy link
Member

DHowett commented Nov 25, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@DHowett DHowett enabled auto-merge (squash) November 25, 2024 22:58
@DHowett DHowett disabled auto-merge November 25, 2024 23:03
@DHowett DHowett merged commit 220c7cd into main Nov 25, 2024
14 of 19 checks passed
@DHowett DHowett deleted the dev/lhecker/18138-revert-dedupe-history branch November 25, 2024 23:03
@DHowett
Copy link
Member

DHowett commented Nov 25, 2024

Admin merge: arm64 leg failure due to vcpkg; remediated

DHowett pushed a commit that referenced this pull request Feb 3, 2025
This reverts commit 5fdfd51,
because 3 people complained about this change VS 1 person
requesting the change to be made in the first place.

Closes #18138
Reopens #17797 for discussion

(cherry picked from commit 220c7cd)
Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgUeWb8
Service-Version: 1.22
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Area-CookedRead The cmd.exe COOKED_READ handling Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-3 A description (P3) Product-Conhost For issues in the Console codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't cycle through command history using the down-arrow
3 participants