Fix order and robustness of CTRL_*_EVENTs #18233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
DHowett
reviewed
Nov 21, 2024
carlos-zamora
approved these changes
Nov 25, 2024
DHowett
approved these changes
Nov 25, 2024
|
admin merge - arm64 vcpkg issue, remediated in main |
DHowett
pushed a commit
that referenced
this pull request
Feb 3, 2025
* This fixes a regression in 391abaf, which caused attached clients to receive CTRL_CLOSE_EVENTs, etc., in oldest-to-newest order, while historically the opposite is expected. * It also changes the behavior of `ProcessCtrlEvents` to dispatch these events no matter whether a client is already dead. This restores the Windows XP to Windows 8.1 behavior. Both of these fixes would address the issue on their own. Closes #15373 ## Validation Steps Performed * CloseTest from our repository shows newest-to-oldest order again. * node gets killed when run under npm and closing the tab. (cherry picked from commit 09d8ac4) Service-Card-Id: PVTI_lADOAF3p4s4AmhmQzgVBZ1o Service-Version: 1.22
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to receive CTRL_CLOSE_EVENTs, etc., in oldest-to-newest order,
while historically the opposite is expected.
ProcessCtrlEventsto dispatchthese events no matter whether a client is already dead.
This restores the Windows XP to Windows 8.1 behavior.
Both of these fixes would address the issue on their own.
Closes #15373
Validation Steps Performed