Fix dispatching of system keys #18444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
carlos-zamora
approved these changes
Jan 21, 2025
DHowett
approved these changes
Jan 21, 2025
| const auto hwnd = msg.hwnd; | ||
| // Each CoreInput window is a child of our IslandWindow. | ||
| // We can figure out the IslandWindow HWND via GetAncestor(). | ||
| const auto hwnd = GetAncestor(msg.hwnd, GA_ROOT); |
There was a problem hiding this comment.
You can consider this an extra. 😄 When I added this code you asked if we can't figure out the IslandWindow from a CoreInput target and I said no. Turns out we can.
lhecker
added
the
AutoMerge
microsoft-github-policy-service
bot
deleted the
dev/lhecker/special-key-dispatch
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the bit check for key down and adds a few comments.
Closes #18331
Validation Steps Performed
Printing the resulting INPUT_RECORDs shows both key down and up events when pressing F7. Alt-Space now also works again.