Make AssemblyCleanup/ClassCleanup execute even if Initialize fails. (#…

…696) Co-authored-by: Andrew Pham <anpha@microsoft.com>
microsoft · Jun 5, 2020 · 7b45d8a · 7b45d8a
1 parent ccc0dd8
commit 7b45d8a
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 16 deletions.
diff --git a/src/Adapter/MSTest.CoreAdapter/Execution/TestAssemblyInfo.cs b/src/Adapter/MSTest.CoreAdapter/Execution/TestAssemblyInfo.cs
@@ -97,12 +97,6 @@ public bool HasExecutableCleanupMethod
                     return false;
                 }
 
-                // If assembly initialization was successful, then only call assembly cleanup.
-                if (this.AssemblyInitializationException != null)
-                {
-                    return false;
-                }
-
                 return true;
             }
         }

diff --git a/src/Adapter/MSTest.CoreAdapter/Execution/TestClassInfo.cs b/src/Adapter/MSTest.CoreAdapter/Execution/TestClassInfo.cs
@@ -161,12 +161,6 @@ public bool HasExecutableCleanupMethod
                     return false;
                 }
 
-                // If class initialization was successful, then only call class cleanup.
-                if (this.ClassInitializationException != null)
-                {
-                    return false;
-                }
-
                 return true;
             }
         }

diff --git a/test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestAssemblyInfoTests.cs b/test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestAssemblyInfoTests.cs
@@ -69,11 +69,12 @@ public void TestAssemblyHasExecutableCleanupMethodShouldReturnFalseIfAssemblyHas
         }
 
         [TestMethod]
-        public void TestAssemblyHasExecutableCleanupMethodShouldReturnFalseIfAssemblyInitializationThrewAnException()
+        public void TestAssemblyHasExecutableCleanupMethodShouldReturnTrueEvenIfAssemblyInitializationThrewAnException()
         {
+            this.testAssemblyInfo.AssemblyCleanupMethod = this.dummyMethodInfo;
             this.testAssemblyInfo.AssemblyInitializationException = new NotImplementedException();
 
-            Assert.IsFalse(this.testAssemblyInfo.HasExecutableCleanupMethod);
+            Assert.IsTrue(this.testAssemblyInfo.HasExecutableCleanupMethod);
         }
 
         [TestMethod]

diff --git a/test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestClassInfoTests.cs b/test/UnitTests/MSTest.CoreAdapter.Unit.Tests/Execution/TestClassInfoTests.cs
@@ -185,12 +185,12 @@ public void TestClassInfoHasExecutableCleanupMethodShouldReturnFalseIfClassDoesN
         }
 
         [TestMethod]
-        public void TestClassInfoHasExecutableCleanupMethodShouldReturnFalseIfClassInitializeThrowsAnException()
+        public void TestClassInfoHasExecutableCleanupMethodShouldReturnTrueEvenIfClassInitializeThrowsAnException()
         {
             this.testClassInfo.ClassCleanupMethod = this.testClassType.GetMethods().First();
             this.testClassInfo.ClassInitializationException = new NotImplementedException();
 
-            Assert.IsFalse(this.testClassInfo.HasExecutableCleanupMethod);
+            Assert.IsTrue(this.testClassInfo.HasExecutableCleanupMethod);
         }
 
         [TestMethod]