Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix debug output clear #1014

Merged
merged 29 commits into from
Dec 2, 2021
Merged

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Nov 29, 2021

Debug output clear had race condition that could cause the StringBuilder to throw, now we lock over both operations to prevent it.

Haplois
Haplois previously approved these changes Nov 29, 2021
@nohwnd nohwnd enabled auto-merge (squash) November 29, 2021 16:30
@nohwnd
Copy link
Member Author

nohwnd commented Dec 1, 2021

The behavior is now what I would expect, and running on repro that crashed before no longer crashes, but tests are broken. I think there are just different assumptions about the behavior and how we receive data. There are also few tests that pass by accident, when dispose runs on the class at just the right moment to trigger Remove count in Dispose to be 2 instead of the more logical 1. Perfect local debugging experience because the test does not pass when you run it alone 🙄

@nohwnd nohwnd merged commit 7109e59 into microsoft:main Dec 2, 2021
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants