-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix debug output clear #1014
Fix debug output clear #1014
Conversation
The behavior is now what I would expect, and running on repro that crashed before no longer crashes, but tests are broken. I think there are just different assumptions about the behavior and how we receive data. There are also few tests that pass by accident, when dispose runs on the class at just the right moment to trigger Remove count in Dispose to be 2 instead of the more logical 1. Perfect local debugging experience because the test does not pass when you run it alone 🙄 |
Debug output clear had race condition that could cause the StringBuilder to throw, now we lock over both operations to prevent it.