Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ship only production runtime files #378

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ship only production runtime files #378

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7b56e8d
Ship only production runtime files - tsdoc-config
osher May 5, 2024
9463254
Ship only production runtime files - tsdoc
May 5, 2024
d6d337b
follow code-review comments
Jun 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tsdoc-config/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,11 @@
},
"homepage": "https://tsdoc.org/",
"main": "lib/index.js",
"files": [
"lib/*.js",
"lib/*.js.map",
"lib/**/*.d.ts"
],
"typings": "lib/index.d.ts",
"license": "MIT",
"dependencies": {
Expand Down
8 changes: 8 additions & 0 deletions tsdoc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@
"homepage": "https://tsdoc.org/",
"main": "lib-commonjs/index.js",
"module": "lib/index.js",
"files": [
"lib-commonjs/*.js",
"lib-commonjs/*.js.map",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These (and the patterns for lib) only match files in the root of the lib-commonjs folder. This project has files that are in nested folders.

Copy link
Author

@osher osher Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha! will fix

will also remove the .js.map per your comment below

...cound't get rush working for me though...

"lib-commonjs/**/*.d.ts",
"lib/*.js",
"lib/*.js.map",
"lib/**/*.d.ts"
],
"typings": "lib/index.d.ts",
"license": "MIT",
"devDependencies": {
Expand Down