This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
#395 Updated banned term rule to find banned terms in property names #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
suggested changes
Sep 13, 2018
There was a problem hiding this comment.
Thanks for the PR @nonasoumy! Great that this was doable in such a small diff to the walker.
However, per the issue's discussion, this is a pretty breaking change as evidenced by the ~90 extra tslint:disable-next-line:no-reserved-keywords added. We'll want this to be an opt-in config option for the rule. Could you please add that in?
|
Well, looks like this from a deleted user - sorry to see you go! I'll go ahead and close this PR for housekeeping. Ghost mystery friend, if you ever want to come back, I'd love to have this PR re-opened! 👻 |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #395