Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid duplicate null check and fix null serialization property name #6066

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

JoshLove-msft
Copy link
Contributor

Fixes #6040

@microsoft-github-policy-service microsoft-github-policy-service bot added the emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp label Feb 20, 2025
Copy link
Member

@m-nash m-nash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some runtime MRW coverage with this base class but looks good

@JoshLove-msft JoshLove-msft added this pull request to the merge queue Feb 20, 2025
Merged via the queue into microsoft:main with commit 7f027f4 Feb 20, 2025
21 checks passed
@JoshLove-msft JoshLove-msft deleted the serialize-null-fix branch February 20, 2025 23:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
emitter:client:csharp Issue for the C# client emitter: @typespec/http-client-csharp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenAI - ChatCompletionOptions serialization issue
3 participants