Restore printing full paths to files containing absolute paths. #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@autoantwort points out that it makes sense for those to be clickable. He also wants us to drop the note: prefix from newlines if we aren't attached to a tty; I'm not sure if that is correct.
BillyONeal
commented
Jul 12, 2024
| @@ -1283,7 +1283,7 @@ DECLARE_MESSAGE(FilesContainAbsolutePath1, | |||
| "followed by a list of found files.", | |||
| "There should be no absolute paths, such as the following, in an installed package. To suppress this " | |||
| "message, add set(VCPKG_POLICY_SKIP_ABSOLUTE_PATHS_CHECK enabled)") | |||
| DECLARE_MESSAGE(FilesContainAbsolutePath2, (), "", "Absolute paths were found in the following files") | |||
| DECLARE_MESSAGE(FilesContainAbsolutePath2, (), "", "Absolute paths found here") | |||
There was a problem hiding this comment.
Suggested change
| DECLARE_MESSAGE(FilesContainAbsolutePath2, (), "", "Absolute paths found here") | |
| DECLARE_MESSAGE(FilesContainAbsolutePath2, (), "", "absolute paths found here") |
BillyONeal
commented
Jul 12, 2024
| @@ -966,11 +964,9 @@ foreach ($bad_dir in @('build-dir', 'downloads', 'installed-root', 'package-dir' | |||
|
|
|||
| $expectedFooter = @" | |||
| $($PortfilePath): note: Adding a call to ``vcpkg_fixup_pkgconfig()`` may fix absolute paths in .pc files | |||
| note: Absolute paths were found in the following files | |||
| $($packagesRoot)$($NativeSlash)vcpkg-policy-absolute-paths_$($Triplet): note: the files are relative to `${CURRENT_PACKAGES_DIR} here | |||
| note: include/vcpkg-policy-absolute-paths.h | |||
There was a problem hiding this comment.
I am a bit sad to lose the form that a user would say in portfile.cmake in order to edit one of these files but making the paths clickable is probably worth it anyway... should we keep printing ${CURRENT_PACKAGES_DIR} here to make it easier for the user to figure that out?
There was a problem hiding this comment.
I can see arguments either way... though doesn't this apply to most post-lint checks? Maybe it should be centralized (printed once at the beginning or end of the post-lint checks if any fired)
|
Old style Current New |
ras0219-msft
approved these changes
Jul 18, 2024
BillyONeal
added a commit
to BillyONeal/vcpkg-tool
that referenced
this pull request
Jul 24, 2024
* In microsoft#1455 I missed making absolute lowercase. * In microsoft#1408 a lot of whitespace was missed leading to output like error: building vtk:x64-linux failed with: BUILD_FAILEDSee https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
BillyONeal
added a commit
that referenced
this pull request
Jul 24, 2024
* In #1455 I missed making absolute lowercase. * In #1408 a lot of whitespace was missed leading to output like error: building vtk:x64-linux failed with: BUILD_FAILEDSee https://learn.microsoft.com/vcpkg/troubleshoot/build-failures?WT.mc_id=vcpkg_inproduct_cli for more information.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@autoantwort points out that it makes sense for those to be clickable.
He also wants us to drop the note: prefix from newlines if we aren't attached to a tty; I'm not sure if that is correct.