Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Alpine's search path for Ninja. #1545

Merged
merged 1 commit into from
Dec 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/vcpkg/tools.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,13 @@ namespace vcpkg
virtual StringView tool_data_name() const override { return Tools::NINJA; }
virtual std::vector<StringView> system_exe_stems() const override { return {Tools::NINJA}; }
virtual std::array<int, 3> default_min_version() const override { return {3, 5, 1}; }
#if !defined(_WIN32)
virtual void add_system_paths(const ReadOnlyFilesystem&, std::vector<Path>& out_candidate_paths) const override
{
// This is where Ninja goes by default on Alpine: https://github.com/microsoft/vcpkg/issues/21218
out_candidate_paths.emplace_back("/usr/lib/ninja-build/bin");
}
#endif // ^^^ !defined(_WIN32)

virtual ExpectedL<std::string> get_version(const ToolCache&, MessageSink&, const Path& exe_path) const override
{
Expand Down