Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[icu] Fix configure failure due to not finding python #10656

Merged
merged 5 commits into from
Apr 27, 2020

Conversation

LilyWangL
Copy link
Contributor

Describe the pull request
Fix configure failure due to not finding python.

@LilyWangL LilyWangL added the info:internal This PR or Issue was filed by the vcpkg team. label Apr 2, 2020
@MVoz
Copy link
Contributor

MVoz commented Apr 2, 2020

maybe it’s worth adding it here

set(POST_INSTALL_COMMAND ${CMAKE_COMMAND} -E remove python37._pth)

      set(POST_INSTALL_COMMAND ${CMAKE_COMMAND} -E remove python37._pth)
      find_program(PYTHON_EXECUTABLE NAMES python python3 python3.7 HINTS ${PATHS}  NO_DEFAULT_PATH)
        vcpkg_add_to_path(PREPEND ${PATHS})
      mark_as_advanced(PYTHON_EXECUTABLE)

and only specify this in the port files

vcpkg_find_acquire_program(PYTHON3)

@Neumann-A
Copy link
Contributor

vcpkg_find_acquire_program should have options to append (APPEND_TO_PATH) or prepend (PREPEND_TO_PATH) to path automatically but that is a completely different issue

@LilyWangL LilyWangL marked this pull request as ready for review April 3, 2020 01:48
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Apr 8, 2020
@ras0219-msft ras0219-msft merged commit 218e87c into microsoft:master Apr 27, 2020
@ras0219-msft
Copy link
Contributor

LGTM. Thanks @LilyWangL, @NancyLi1013, and @Neumann-A!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants