Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[implot] Add new port #11920

Merged
merged 8 commits into from
Jul 7, 2020
Merged

[implot] Add new port #11920

merged 8 commits into from
Jul 7, 2020

Conversation

RT2Code
Copy link
Contributor

@RT2Code RT2Code commented Jun 13, 2020

@LilyWangL LilyWangL changed the title [implot] Initial port [implot] Add new port Jun 15, 2020
@LilyWangL LilyWangL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Jun 15, 2020
@LilyWangL
Copy link
Contributor

Thanks for your PR. Now this port build failed with this error:
buildtrees\implot\src\v0.3-d0514ebfd6\implot.cpp(63): fatal error C1083: Cannot open include file: 'imgui_internal.h': No such file or directory
Could you please continue to fix this PR?

@RT2Code
Copy link
Contributor Author

RT2Code commented Jun 15, 2020

It's because this library requires Imgui internal header to be publicly available, which I did with #11919.

This port should build just fine when #11919 will be merged.

@LilyWangL LilyWangL added depends:different-pr This PR or Issue depends on a PR which has been filed and removed requires:author-response labels Jun 16, 2020
@RT2Code
Copy link
Contributor Author

RT2Code commented Jun 23, 2020

Now that #11919 is merged, can you run the tests again? It should build now. :)

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

@RT222 Now implot build failed on CI with the following error:

implot.cpp.obj : error LNK2019: unresolved external symbol "struct ImGuiIO & __cdecl ImGui::GetIO(void)" (?GetIO@ImGui@@YAAAUImGuiIO@@XZ) referenced in function "bool __cdecl ImPlot::BeginPlot(char const *,char const *,char const *,struct ImVec2 const &,int,int,int,int,int)" (?BeginPlot@ImPlot@@YA_NPBD00ABUImVec2@@HHHHH@Z)
implot_demo.cpp.obj : error LNK2001: unresolved external symbol "struct ImGuiIO & __cdecl ImGui::GetIO(void)" (?GetIO@ImGui@@YAAAUImGuiIO@@XZ)
implot.cpp.obj : error LNK2019: unresolved external symbol "struct ImGuiStyle & __cdecl ImGui::GetStyle(void)" (?GetStyle@ImGui@@YAAAUImGuiStyle@@XZ) referenced in function "void __cdecl ImPlot::UpdateAxisColor(int,struct ImPlot::ImPlotAxisColor *)" (?UpdateAxisColor@ImPlot@@YAXHPAUImPlotAxisColor@1@@Z)
implot_demo.cpp.obj : error LNK2001: unresolved external symbol "struct ImGuiStyle & __cdecl ImGui::GetStyle(void)" (?GetStyle@ImGui@@YAAAUImGuiStyle@@XZ)
implot.cpp.obj : error LNK2019: unresolved external symbol "bool __cdecl ImGui::BeginChild(char const *,struct ImVec2 const &,bool,int)" (?BeginChild@ImGui@@YA_NPBDABUImVec2@@_NH@Z) referenced in function "bool __cdecl ImPlot::BeginPlot(char const *,char const *,char const *,struct ImVec2 const &,int,int,int,int,int)" (?BeginPlot@ImPlot@@YA_NPBD00ABUImVec2@@HHHHH@Z)
implot.cpp.obj : error LNK2019: unresolved external symbol "void __cdecl ImGui::EndChild(void)" (?EndChild@ImGui@@YAXXZ) referenced in function "public: void __thiscall ImPlot::ImPlotContext::Reset(void)" (?Reset@ImPlotContext@ImPlot@@QAEXXZ)
implot.cpp.obj : error LNK2019: unresolved external symbol "struct ImDrawList * __cdecl ImGui::GetWindowDrawList(void)" (?GetWindowDrawList@ImGui@@YAPAUImDrawList@@XZ) referenced in function "void __cdecl ImPlot::PlotText(char const *,double,double,bool,struct ImVec2 const &)" (?PlotText@ImPlot@@YAXPBDNN_NABUImVec2@@@Z)
implot_demo.cpp.obj : error LNK2001: unresolved external symbol "struct ImDrawList * __cdecl ImGui::GetWindowDrawList(void)" (?GetWindowDrawList@ImGui@@YAPAUImDrawList@@XZ)

Could you please continue to fix this PR?

@LilyWangL LilyWangL added requires:author-response and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Jun 24, 2020
@RT2Code
Copy link
Contributor Author

RT2Code commented Jun 24, 2020

Sorry about that, it should be fixed now.

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL
Copy link
Contributor

Hi, @RT222 Now implot build failed on Linux with the following error:

buildtrees/implot/src/v0.3-d0514ebfd6/implot.h:26:10: fatal error: imgui.h: No such file or directory
 #include "imgui.h"
          ^~~~~~~~~
compilation terminated.

@RT2Code
Copy link
Contributor Author

RT2Code commented Jul 1, 2020

It should now build on Linux as soon as #12155 is merged.

@RT2Code
Copy link
Contributor Author

RT2Code commented Jul 2, 2020

#12155 have been merged, can you please run the tests again? It should build everywhere at last. :)

@LilyWangL
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Jul 2, 2020
@ras0219-msft ras0219-msft merged commit 4425bf3 into microsoft:master Jul 7, 2020
@ras0219-msft
Copy link
Contributor

LGTM, thanks for the PR!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants