-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[mingw] add VCPKG cmake_system_name #11934
Conversation
@@ -171,6 +174,7 @@ namespace vcpkg | |||
case Identifier::android: return true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "Android"); | |||
case Identifier::emscripten: return true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "Emscripten"); | |||
case Identifier::wasm32: return true_if_exists_and_equal("VCPKG_TARGET_ARCHITECTURE", "wasm32"); | |||
case Identifier::mingw: return true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "mingw"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "mingw")
->
true_if_exists_and_equal("VCPKG_CMAKE_SYSTEM_NAME", "MinGW")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
logic
VCPKG_CMAKE_SYSTEM_NAME MinGW
vcpkg/triplets/community/x64-mingw.cmake
Line 6 in ffa7fd2
why is there no compiler definition? as in the example
https://gitlab.kitware.com/cmake/community/-/wikis/doc/cmake/cross_compiling/Mingw
https://gitlab.kitware.com/cmake/community/uploads/265a703419aeaa26bef8044b92911e37/Toolchain-cross-mingw32-linux.cmake