Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[glib/gtk/atk] Add pkgconfig file #12326

Closed
wants to merge 3 commits into from

Conversation

PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Jul 8, 2020

Fixes #12282 #7641

  1. Add package version for glib
  2. Add atk and gtk pkgconfig file
  3. Gtk: remove '.0' for ARCHIVE_OUTPUT_NAME
    Before: gdk-3.0.lib
    Now: gdk-3.lib
    Since the library name doesn't have '.0' which used in gtk+-3.0.pc.in file. Not sure why it added before.

@PhoebeHui PhoebeHui added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Jul 8, 2020
@sdroege
Copy link

sdroege commented Jul 8, 2020

The GTK pkg-config file should depend on the ones from gdk, pango, pangocairo, harfbuzz, cairo, cairo-gobject, gdk-pixbuf (directly or indirectly). Unless those are all there already this would be incomplete.

@rukai
Copy link

rukai commented Jul 8, 2020

I checked out your branch, then did:

./bootstrap-vcpkg.bat
./vcpkg remove gtk:x64-windows
./vcpkg install gtk:x64-windows

But it failed with:

PS C:\Users\rukai\Projects\vcpkg> ./vcpkg install gtk:x64-windows
Computing installation plan...
The following packages will be built and installed:
    gtk[core]:x64-windows
Starting package 1/1: gtk:x64-windows
Building package gtk[core]:x64-windows...
-- Using cached C:/Users/rukai/Projects/vcpkg/downloads/gtk+-3.22.19.tar.xz
-- Cleaning sources at C:/Users/rukai/Projects/vcpkg/buildtrees/gtk/src/gtk+-3-b723a7b846.clean. Pass --editable to vcpkg to reuse sources.
-- Extracting source C:/Users/rukai/Projects/vcpkg/downloads/gtk+-3.22.19.tar.xz
-- Using source at C:/Users/rukai/Projects/vcpkg/buildtrees/gtk/src/gtk+-3-b723a7b846.clean
-- Configuring x64-windows-dbg
-- Configuring x64-windows-rel
-- Building x64-windows-dbg
-- Building x64-windows-rel
-- Fixing pkgconfig
-- Fixing pkgconfig - release
-- Checking file: C:/Users/rukai/Projects/vcpkg/packages/gtk_x64-windows/lib/pkgconfig/gail-3.0.pc
CMake Error at scripts/cmake/vcpkg_fixup_pkgconfig.cmake:184 (message):
  Package atk not found! If it is a system package add it to the
  SYSTEM_PACKAGES parameter for the vcpkg_fixup_pkgconfig call! Otherwise,
  corret the *.pc file
Call Stack (most recent call first):
  scripts/cmake/vcpkg_fixup_pkgconfig.cmake:234 (vcpkg_fixup_pkgconfig_check_libraries)
  ports/gtk/portfile.cmake:40 (vcpkg_fixup_pkgconfig)
  scripts/ports.cmake:76 (include)


Error: Building package gtk:x64-windows failed with: BUILD_FAILED
Please ensure you're using the latest portfiles with `.\vcpkg update`, then
submit an issue at https://github.com/Microsoft/vcpkg/issues including:
  Package: gtk:x64-windows
  Vcpkg version: 2020.06.15-nohash

Additionally, attach any relevant sections from the log files above.
PS C:\Users\rukai\Projects\vcpkg>

@PhoebeHui
Copy link
Contributor Author

@sdroege, thanks for your review, I will try to add pkgconfig file to others depedency ports.

@rukai, the atk port need rebuild in your local machine.

@PhoebeHui
Copy link
Contributor Author

Some pkgconfig file for dependency ports added in #11776

@PhoebeHui
Copy link
Contributor Author

I will continue this PR after PR #11550 and #11776 merged.

@PhoebeHui PhoebeHui added the depends:different-pr This PR or Issue depends on a PR which has been filed label Sep 18, 2020
@PhoebeHui
Copy link
Contributor Author

List dependency ports which are lacking of the .pc file currently.

  • cairo
  • gdk-pixbuf
  • harfbuzz
  • pango
  • pixman
  • ragel
  • zlib
  • brotli
  • fontconfig
  • freetype
  • json-c
  • libffi
  • libpng
  • pcre
  • atk
  • glib

@PhoebeHui
Copy link
Contributor Author

Closing this PR now. I will reopen it once I have time.

@PhoebeHui PhoebeHui closed this Feb 7, 2021
@PhoebeHui PhoebeHui deleted the dev/Phoebe/gtk branch June 17, 2021 05:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist depends:different-pr This PR or Issue depends on a PR which has been filed info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gtk missing and broken pkgconfig files
4 participants