[aws-sdk-cpp] Make aws-sdk-cpp rpath relocatable #14546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is important since vcpkg offers binary caching which could be shared between different machines (as long as both machines use the same "toolchains" [more technically, as long as the vcpkg hash is the same])
PhoebeHui
changed the title
PhoebeHui
requested changes
Nov 13, 2020
There was a problem hiding this comment.
@klalumiere, thanks for the PR!
Could you also update the Port-Version from 0 to 1 in CONTROL file?
PhoebeHui
added
category:port-bug
I always forget about this 😳 😆. Done ✔️. |
PhoebeHui
added
requires:all-feature-testing
|
All features test passed with x64-windows. |
PhoebeHui
removed
the
requires:all-feature-testing
PhoebeHui
approved these changes
Nov 13, 2020
|
Thanks @klalumiere 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is important since vcpkg offers binary caching which could be
shared between different machines (as long as both machines use the same
"toolchains" [more technically, as long as the vcpkg hash is the same])
Describe the pull request
What does your PR fix? Fixes Port aws-sdk-cpp has a non relocatable rpath, which becomes problematic when used with (remote) vcpkg binary caching #14544
Which triplets are supported/not supported? Have you updated the CI baseline? No changes related to triplets support or to CI baseline.
Does your PR follow the maintainer guide? Yes.