Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[tbb] explicitly disable hwloc feature for UWP #34648

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

ilya-lavrenov
Copy link
Contributor

Actually, TBB should support UWP according to https://www.intel.com/content/www/us/en/developer/articles/technical/using-intel-performance-libraries-in-universal-windows-drivers.html, so I will create an issue for TBB team to fix it.
Once it's fixed, hwloc should still be disabled for UWP as it does not support this platform.

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@ilya-lavrenov ilya-lavrenov changed the title tbb: explicitly disable hwloc feature for UWP [tbb] explicitly disable hwloc feature for UWP Oct 21, 2023
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Oct 23, 2023
@jimwang118
Copy link
Contributor

All features passed with following triplets:

x86-windows
x64-windows

@jimwang118 jimwang118 added the info:reviewed Pull Request changes follow basic guidelines label Oct 23, 2023
@JavierMatosD JavierMatosD merged commit 0d8e0f2 into microsoft:master Oct 23, 2023
@ilya-lavrenov ilya-lavrenov deleted the tbb branch October 23, 2023 18:54
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants