Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[vcpkg baseline] Add discordcoreapi omplapp to ci.baseline.txt #40229

Merged

Conversation

WangWeiLin-MV
Copy link
Contributor

@WangWeiLin-MV WangWeiLin-MV commented Aug 2, 2024

Relieve Pipelines - Run 20240725.1 (azure.com) "Nothing to show. Final logs are missing. This can happen when the job is cancelled or times out.", that CI test hanging on x64-linux.

So mark port discordcoreapi as skip for x64-linux.


Port discordcoreapi failed with dependency #39693 (comment)

discordcoreapi:x64-uwp=fail
discordcoreapi:x64-windows=fail
discordcoreapi:x64-windows-static=fail
discordcoreapi:x64-windows-static-md=fail

Port omplapp failed with FILE_CONFLICTS #40151

omplapp:arm64-osx=skip
omplapp:x64-osx=skip
omplapp:x64-linux=skip

@WangWeiLin-MV WangWeiLin-MV added info:internal This PR or Issue was filed by the vcpkg team. category:infrastructure Pertaining to the CI/Testing infrastrucutre labels Aug 2, 2024
@WangWeiLin-MV
Copy link
Contributor Author

WangWeiLin-MV commented Aug 2, 2024

More Information

Based on local testing for building discordcoreapi on linux, memory seems to be exhausted very quickly. Afterwards the build goes single-threaded and hangs for a long time.

Based on the running CI log, the build-time log stay -- Building x64-linux-dbg same as local.

Other triplets build normally. (the build fails in about 3 minutes Pipelines - Run 20240723.1 (azure.com))

So, mark it from 'fail' to skip for x64-linux.

Regression

Before it marks as 'fail' on #35358, but it built normally. (the build fails in about 3 minutes)

Regression from #39693, the updating of its dependency jsonifier did not trigger the build of discordcoreapi Pipelines - Run 20240723.12 (azure.com). Further investigation is required. Updated below #40229 (comment) .

@WangWeiLin-MV WangWeiLin-MV force-pushed the scripts/ci/discordcoreapi-linux-hang branch from 1bf00ed to e7d2a48 Compare August 2, 2024 08:50
@WangWeiLin-MV WangWeiLin-MV changed the title [scripts/ci] Port discordcoreapi hang on linux [scripts/ci] Port discordcoreapi hang on linux [scripts/ci][discordcoreapi][omplapp] ci.baseline.txt add known issue Aug 2, 2024
@WangWeiLin-MV WangWeiLin-MV changed the title [scripts/ci] Port discordcoreapi hang on linux [scripts/ci][discordcoreapi][omplapp] ci.baseline.txt add known issue [vcpkg baseline] Add discordcoreapi omplapp to ci.baseline.txt Aug 2, 2024
@WangWeiLin-MV
Copy link
Contributor Author

Depends on #40231 or #40249

@WangWeiLin-MV WangWeiLin-MV added the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 6, 2024
@talregev
Copy link
Contributor

talregev commented Aug 6, 2024

@WangWeiLin-MV
#40249 Already merged.

@WangWeiLin-MV WangWeiLin-MV removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 7, 2024
@dg0yt
Copy link
Contributor

dg0yt commented Aug 7, 2024

Please speed this up and mark this ready-for-review.

@WangWeiLin-MV
Copy link
Contributor Author

WangWeiLin-MV commented Aug 7, 2024

Please speed this up and mark this ready-for-review.

According to the CI log, its progress has reached 4/5

Updates: Depends on #40327

@dg0yt
Copy link
Contributor

dg0yt commented Aug 7, 2024

Please speed this up and mark this ready-for-review.

According to the CI log, its progress has reached 4/5

Updates: Depends on #40327

This PR can be reviewed and merged despite the build errors. It might even be necessary.

@data-queue
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

JonLiu1993
JonLiu1993 previously approved these changes Aug 9, 2024
@WangWeiLin-MV
Copy link
Contributor Author

WangWeiLin-MV commented Aug 9, 2024

Failed with omplapp:x64-linux failed with FILE_CONFLICTS, Pipelines - Run 20240809.2 (azure.com), same error, so add item:

omplapp:x64-linux=skip

@WangWeiLin-MV
Copy link
Contributor Author

#40229 (comment)

Regression

Before it marks as 'fail' on #35358, but it built normally. (the build fails in about 3 minutes)

Regression from #39693, the updating of its dependency jsonifier did not trigger the build of discordcoreapi Pipelines - Run 20240723.12 (azure.com). Further investigation is required.

Updates:

PR checks miss the hang-error due to various reasons:

@data-queue data-queue merged commit 0440056 into microsoft:master Aug 10, 2024
16 checks passed
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Aug 12, 2024
@WangWeiLin-MV WangWeiLin-MV deleted the scripts/ci/discordcoreapi-linux-hang branch August 12, 2024 03:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category:infrastructure Pertaining to the CI/Testing infrastrucutre info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants