Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[curlcpp] Add curlcpp port #40543

Merged
merged 5 commits into from
Aug 26, 2024
Merged

[curlcpp] Add curlcpp port #40543

merged 5 commits into from
Aug 26, 2024

Conversation

troyan1337
Copy link
Contributor

  • Changes comply with the maintainer guide.
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@troyan1337
Copy link
Contributor Author

@microsoft-github-policy-service agree

- ${CURLCPP_HEADER_LIST}
- )
-else()
- add_library(curlcpp ${BUILD_SHARED_LIBS}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG, JosephP91/curlcpp#154 and no action yet. Do we really want this port?

At least trim the change to a single line:

-    add_library(curlcpp ${BUILD_SHARED_LIBS}
+    add_library(curlcpp SHARED

(plus context)

@LilyWangLL LilyWangLL added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 20, 2024
@troyan1337 troyan1337 marked this pull request as ready for review August 20, 2024 16:13
@LilyWangLL
Copy link
Contributor

Usage passed on x64-windows.

@LilyWangLL LilyWangLL added the info:reviewed Pull Request changes follow basic guidelines label Aug 23, 2024
@vicroms vicroms merged commit 3c12be0 into microsoft:master Aug 26, 2024
16 checks passed
@anders-wind anders-wind mentioned this pull request Sep 2, 2024
7 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants