Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[qca] making softstore plugin a feature #43182

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

m-kuhn
Copy link
Contributor

@m-kuhn m-kuhn commented Jan 9, 2025

No description provided.

@JavierMatosD
Copy link
Contributor

@m-kuhn, it looks like this was being built by default. Why the change to a feature?

@JavierMatosD JavierMatosD marked this pull request as draft January 9, 2025 15:11
@m-kuhn
Copy link
Contributor Author

m-kuhn commented Jan 9, 2025

It's crashing for me (with an osx-dynamic triplet) on load in specific scenarios and I don't require it there, so I prefer to disable this plugin. I can also make it a default feature to avoid a change in behavior for existing users

@m-kuhn m-kuhn marked this pull request as ready for review January 9, 2025 16:59
@JavierMatosD JavierMatosD added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Jan 9, 2025
@m-kuhn m-kuhn changed the title [qca] new feature softstore [qca] making softstore plugin a feature Jan 9, 2025
@JavierMatosD
Copy link
Contributor

@AugP, @ras0219-msft, @vicroms, @BillyONeal, and I discussed this today.

@ras0219-msft - "If its broken for osx-dynamic, why not disable it entirely for osx-dynamic? At the very least, if there is an issue then there should be a report to upstream."

@JavierMatosD JavierMatosD marked this pull request as draft January 9, 2025 23:17
@JavierMatosD JavierMatosD marked this pull request as draft January 9, 2025 23:17
@jimwang118 jimwang118 self-assigned this Jan 10, 2025
@jimwang118 jimwang118 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Jan 10, 2025
@m-kuhn
Copy link
Contributor Author

m-kuhn commented Jan 10, 2025

@JavierMatosD It is possible that there is a conflict with other plugins / other components in my build and that in other scenarios softstore works as expected. That's why I preferred to make it a feature instead.
If you prefer me to globally disable it on osx-dynamic I can do that as well.

Issue created: https://bugs.kde.org/show_bug.cgi?id=498453

@m-kuhn m-kuhn marked this pull request as ready for review January 10, 2025 07:52
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants