Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fixes Issue 117154 - VScode Emmet missing HTML "hgroup" tag #55

Merged
merged 3 commits into from
Mar 2, 2021
Merged

Fixes Issue 117154 - VScode Emmet missing HTML "hgroup" tag #55

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db492b2
add hgroup
OBITORASU Feb 23, 2021
bff19c5
Add test for hgroup
OBITORASU Feb 23, 2021
14bee9b
Moved the test a bit later in the list
OBITORASU Mar 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ export const htmlData = {
"body", "head", "html",
"address", "blockquote", "dd", "div", "section", "article", "aside", "header", "footer", "nav", "menu", "dl", "dt", "fieldset", "form", "frame", "frameset", "h1", "h2", "h3", "h4", "h5", "h6", "iframe", "noframes", "object", "ol", "p", "ul", "applet", "center", "dir", "hr", "pre",
"a", "abbr", "acronym", "area", "b", "base", "basefont", "bdo", "big", "br", "button", "caption", "cite", "code", "col", "colgroup", "del", "dfn", "em", "font", "i", "img", "input", "ins", "isindex", "kbd", "label", "legend", "li", "link", "map", "meta", "noscript", "optgroup", "option", "param", "q", "s", "samp", "script", "select", "small", "span", "strike", "strong", "style", "sub", "sup", "table", "tbody", "td", "textarea", "tfoot", "th", "thead", "title", "tr", "tt", "u", "var",
"canvas", "main", "figure", "plaintext", "figcaption"
"canvas", "main", "figure", "plaintext", "figcaption", "hgroup"
]
}
3 changes: 3 additions & 0 deletions src/test/expand.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,9 @@ describe('Expand Abbreviations', () => {
// https://github.com/microsoft/vscode/issues/114923
testExpandWithCompletion('html', 'figcaption', '<figcaption>${0}</figcaption>');

// https://github.com/microsoft/vscode/issues/117154
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: can you move this addition to a later part of the document? The tests are currently somewhat sorted by issue id

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing!

testExpandWithCompletion('html', 'hgroup', '<hgroup>${0}</hgroup>');

// https://github.com/microsoft/vscode/issues/115623
testCountCompletions('html', 'html', 1);
testCountCompletions('html', 'body', 1);
Expand Down