Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

The completion suggest is invalid if some comments contain chinese #77

Closed
holmeszyx opened this issue Nov 24, 2015 · 5 comments
Closed

Comments

@holmeszyx
Copy link

I think it may happen when comments contain no only chinese but also other no acsii characters.(like Japanese, no testing)

See Image (A) below. Suggests list for package fmt never show when press '.' after 'fmt'.
If I delete 测试 in line 8 like image (B), everthing be ok now.

(A.)
invalid

(B.)
normal

Test code.

package main

import (
    "fmt"
)

// Test1 this is for 测试
func Test1(i int)  {
    i = 123
}

func main() {
    fmt.
}
@Reposkeeper-zz
Copy link

not only comments. if unicode in Go Strings, the completion suggest is also invalid.

@lukehoban
Copy link
Member

@holmeszyx @reposkeeper Thanks for this. Pretty sure this was fixed with #77. I just pushed an update to vscode-go to 0.6.13 with this fix. Could you try upgrading, and if you still see this issue, please reactivate.

@dyxushuai
Copy link

The godef has the same problem.

@lukehoban
Copy link
Member

Thanks @johnsmithx. I've pushed additional fixes for this with some of the other features. Hover, goto-definition, rename, and find-references apparently all had a similar problem but should now be fixed.

See 328ef9e.

@dyxushuai
Copy link

@lukehoban Good job!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 23, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants