This repository was archived by the owner on Jul 15, 2023. It is now read-only.
goMain.ts add commands to Go: Show All Commands #1947
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commands added : * Go to definition * Go to implementation * Go to symbol in file * Go to symbol in workspace fixes microsoft#1822
|
|
ramya-rao-a
reviewed
Sep 27, 2018
| extCommands.push({ | ||
| command : 'editor.action.goToTypeDefinition', | ||
| title : 'Go : Go to Type Definition', | ||
| description : 'Go : invokes the GoDefinitionProvider' |
There was a problem hiding this comment.
- This should be
editor.action.goToDeclarationwith titleGo to Definition. - We can skip the description. It doesnt get used in the
Show all commandsfeature - Let's not include the prefix
Go:in the title.
The prefix is for commands explicitly registered and implemented by the Go extension.
Where as these 4 commands that we are adding is registered in core VS Code an is only implemented by the Go extension
There was a problem hiding this comment.
- will change to
editor.action.goToDeclaration. - description i kept for sake of documentation. it was hard for me to see the connection between the various
Providersin the vscode-go extension and their corresponding internal commands. thats why initially i started with creating a new command - ok will remove the 'Go:' prefix, else it may be thought of a separate command.
in fact i was looking for some api to get the complete command object for these four commands, so that title, description etc can be reused directly. i couldn't find so created the literals.
|
Thanks for the PR! By the way, if you are interested in winning a t-shirt in the hactoberfest, close this PR and open a new one in October. See https://open.microsoft.com/2018/09/18/hacktoberfest-2018-microsoft/?WT.mc_id=hacktoberfest-twitter-beverst for more details |
ramya-rao-a
reviewed
Sep 27, 2018
| command : 'editor.action.goToImplementation', | ||
| title : 'Go : Go to Implementation', | ||
| description : 'Go : invokes the GoImplementationProvider' | ||
| }) |
There was a problem hiding this comment.
Missing semicolon for each of the push is causing linting errors in the build
There was a problem hiding this comment.
thanks. i am new to type script.
is there a way to run such checks locally? before sending the PR
There was a problem hiding this comment.
Yes, you can run npm run lint in the terminal
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commands added :
fixes #1822