Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

fix stopOnEntry #2762

Merged
merged 2 commits into from
Sep 27, 2019
Merged

fix stopOnEntry #2762

merged 2 commits into from
Sep 27, 2019

Conversation

jhendrixMSFT
Copy link
Member

Send a dummy thread to vscode when stopped on entry as there are no
threads in the process yet.
Send the stop event with the same dummy thread ID.

Send a dummy thread to vscode when stopped on entry as there are no
threads in the process yet.
Send the stop event with the same dummy thread ID.
@jhendrixMSFT
Copy link
Member Author

Fixes #763

@ramya-rao-a
Copy link
Contributor

cc @quoctruong

Copy link
Contributor

@quoctruong quoctruong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Does this work with remote attach scenario?

@jhendrixMSFT
Copy link
Member Author

Good question, I tried it and it doesn't work. While I'm sure it can be fixed, I want to ask if we think this scenario is valuable? If not then I suggest removing stopOnEntry from the attach option.
I personally feel like this isn't really useful and in my experience I don't recall other debuggers doing this. However I might be overlooking some use case.

@quoctruong
Copy link
Contributor

Yes, I think by default, the program for remote attach scenario wouldn't start until a debugger is connected to it anyway. Therefore, this option may not be needed for that.

@jhendrixMSFT
Copy link
Member Author

@ramya-rao-a are you ok with removing stopOnEntry from attach?

@ramya-rao-a
Copy link
Contributor

@jhendrixMSFT Yes, I am fine with removing stopOnEntry for attach scenarios and ignore it for the launch request in debug mode as well

@ramya-rao-a ramya-rao-a merged commit 9874b40 into microsoft:master Sep 27, 2019
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants