This repository was archived by the owner on Jul 15, 2023. It is now read-only.
Gate the check for gopls updates using a setting #2773
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in #2768 and #2767, the implicit calls to https://proxy.golang.org/golang.org/x/tools/gopls/@v/list can fail in multiple scenarios.
In VS Code, we also want to follow the guideline of not making any outgoing calls over the network unless it is done as part of a feature resulting from an explicit user action which the user is aware of.
Exceptions to this rule should be documented and a setting should be provided for the user to opt in/out.
Keeping this in mind, the recent feature of making calls to https://proxy.golang.org/golang.org is being updated as follows in this PR
extensions.autoCheckUpdates
setting in VS Codegopls
in the extension