using vscode API to store and load connection profiles #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevcunnane
approved these changes
Sep 20, 2017
| @@ -77,16 +63,14 @@ export class ConnectionConfig implements IConnectionConfig { | |||
| }; | |||
|
|
|||
| // Read from user settings | |||
| let parsedSettingsFile = this.readAndParseSettingsFile(ConnectionConfig.configFilePath); | |||
| let userProfiles = this.getProfilesFromParsedSettingsFile(parsedSettingsFile); | |||
| let userProfiles = this.getProfilesFromSettingsFile(); | |||
There was a problem hiding this comment.
Minor: remove File from the name since it's no longer a real file read, it's to/from an API that could store anywhere
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
using workspaceConfiguration to store connections to user/workspace settings and also loading from the settings.
Fixed the tests based on latest changes.
Also fixed a bug which connections using Windows auth were added twice to recent history.