Fixes microsoft/monaco-editor#5

microsoft · Jun 23, 2016 · b6943a1 · b6943a1
1 parent eefcdc9
commit b6943a1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/build/monaco/CHANGELOG.md b/build/monaco/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## [0.5.0]
 
+### Notable fixes
+- Broken configurations (loading from `file://` or misconfigured cross-domain loading) now load the web worker code in the UI thread. This caused a breaking change in the behaviour of `monaco.editor.createWebWorker`
+- The right-pointing mouse pointer is oversized in high DPI - [issue](https://github.com/Microsoft/monaco-editor/issues/5)
+
 ### Breaking changes
-- `createWebWorker` now loads the AMD module and calls `create` and passes in as first argument a context of type `monaco.worker.IWorkerContext` and as second argument the `initData`. This breaking change was needed to allow handling the case of misconfigured web workers (running of a file protocol or a cross-domain case)
+- `monaco.editor.createWebWorker` now loads the AMD module and calls `create` and passes in as first argument a context of type `monaco.worker.IWorkerContext` and as second argument the `initData`. This breaking change was needed to allow handling the case of misconfigured web workers (running on a file protocol or the cross-domain case)
 - the `CodeActionProvider.provideCodeActions` now gets passed in a `CodeActionContext` that contains the markers at the relevant range.
diff --git a/src/vs/editor/browser/viewParts/lineNumbers/lineNumbers.css b/src/vs/editor/browser/viewParts/lineNumbers/lineNumbers.css
@@ -6,18 +6,21 @@
 .monaco-editor .margin-view-overlays .line-numbers {
 	position: absolute;
 	text-align: right;
+	display: inline-block;
+	vertical-align: middle;
+	box-sizing: border-box;
+	cursor: default;
+}
+
+.monaco-workbench .monaco-editor .margin-view-overlays .line-numbers {
 	/* Specific fix for blurry cursor on hdpi screens in Chrome and Chromium (Windows and other) */
 	cursor: -webkit-image-set(
 		url('./flipped-cursor.svg') 1x,
 		url('./flipped-cursor-2x.svg') 2x
 	) 30 0, default;
-
-	display: inline-block;
-	vertical-align: middle;
-	box-sizing: border-box;
 }
 
-.monaco-editor.mac .margin-view-overlays .line-numbers {
+.monaco-workbench .monaco-editor.mac .margin-view-overlays .line-numbers {
 	/* Specific fix for blurry cursor on hdpi screens in Chrome and Chromium (Mac) */
 	cursor: -webkit-image-set(
 		url('./flipped-cursor-mac.svg') 1x,