Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Allow resolvers to signal a fatal failure during the initial connection #162590

Closed
alexdima opened this issue Oct 3, 2022 · 0 comments · Fixed by #164279
Closed

Allow resolvers to signal a fatal failure during the initial connection #162590

alexdima opened this issue Oct 3, 2022 · 0 comments · Fixed by #164279
Assignees
@alexdima
Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming remote-connection Issues about the remote connection
Milestone
October 2022

Comments

@alexdima
Copy link
Member

alexdima commented Oct 3, 2022

After #127565 , VS Code will always retry the initial connection for a few times.

It would be good if a resolver could signal via RemoteAuthorityResolverError.NotAvailable that the resolver ran into a fatal error and no further retry attempts should be made.

cc @roblourens @eleanorjboyd
@alexdima alexdima self-assigned this Oct 3, 2022
@alexdima alexdima added the remote-connection Issues about the remote connection label Oct 3, 2022
@alexdima alexdima added this to the October 2022 milestone Oct 3, 2022
@eleanorjboyd eleanorjboyd mentioned this issue Oct 4, 2022
Closed
@alexdima alexdima added the plan-item VS Code - planned item for upcoming label Oct 7, 2022
@kieferrm kieferrm mentioned this issue Oct 10, 2022
Closed
8 tasks
@eleanorjboyd eleanorjboyd mentioned this issue Nov 10, 2022
Closed
@alexdima alexdima mentioned this issue Oct 21, 2022
Merged
alexdima added a commit that referenced this issue Oct 21, 2022
@alexdima
Fixes #162590: Do not retry during the initial connection attempt if …
fe9037b 
…the resolver throws a `RemoteAuthorityResolverError.NotAvailable` error
alexdima added a commit that referenced this issue Oct 21, 2022
@alexdima
Do not retry during the initial connection attempt if the resolver th…
31a4ede 
…rows a `RemoteAuthorityResolverError.NotAvailable` error (#164279)

Fixes #162590: Do not retry during the initial connection attempt if the resolver throws a `RemoteAuthorityResolverError.NotAvailable` error
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Oct 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2022
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@alexdima alexdima

Labels
insiders-released Patch has been released in VS Code Insiders plan-item VS Code - planned item for upcoming remote-connection Issues about the remote connection
Projects
None yet
Milestone
October 2022
2 participants
@alexdima @vscodenpa