Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Specify what is in the event data for env.onDidChangeShell #194229

Closed
amunger opened this issue Sep 26, 2023 · 0 comments · Fixed by #194307
Closed

Specify what is in the event data for env.onDidChangeShell #194229

amunger opened this issue Sep 26, 2023 · 0 comments · Fixed by #194307
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
September 2023

Comments

@amunger
Copy link
Contributor

amunger commented Sep 26, 2023

Testing #194028

'env.onDidChangeShell' tsdoc does not specify what the event data string will contain.
It looks like it's the path to the newly selected default shell.
@Tyriar Tyriar added this to the September 2023 milestone Sep 26, 2023
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Sep 26, 2023
Tyriar added a commit that referenced this issue Sep 27, 2023
@Tyriar
Describe onDidChangeShell data
a625311 
Fixes #194229
@Tyriar Tyriar mentioned this issue Sep 27, 2023
Merged
@vscodenpa vscodenpa added unreleased Patch has not yet been released in VS Code Insiders insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Sep 27, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Sep 28, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
September 2023
Development

Successfully merging a pull request may close this issue.

Describe onDidChangeShell data microsoft/vscode
4 participants
@amunger @Tyriar @rzhao271 @vscodenpa