Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Typescript matchers doesn't recognize tsc output with pretty option enabled #46324

Closed
kijowski opened this issue Mar 22, 2018 · 2 comments
Closed
Assignees
Labels
tasks Task system issues verified Verification succeeded
Milestone

Comments

@kijowski
Copy link

  • VSCode Version: 1.21.1
  • OS Version: Windows 10

Steps to Reproduce:

  1. Install tsc 2.7.2
  2. Create fresh project with tsc --init
  3. Create HelloWorlds.ts
  4. Edit tsconfig.json file and add "pretty": true
  5. Write some invalid code e.g. const x: number = 1 + "1"; . There should be a problem reported in problems tab.
  6. Close the HelloWorlds.ts editor window. Error from problems tab disappear.
  7. Run Task > pick the build task
  8. After compilation ends there are no problems in the problems tab.
  9. Run Task > pick the watch task
  10. Compilation ends but Building... in the status line doesn't disappear.

Does this issue occur when all extensions are disabled?: Yes

It seems that enabling pretty option in tsconfig breaks $tsc and $tsc-watch problem matchers. Enabling this option changes the output of typescript compilation (e.g. timestamp are in square brackets) and this is probably confusing above-mentioned matchers.

There is a connected bug report #44018 but the resolution there went in other direction (multiple lines from terminal #44192).

@vscodebot
Copy link

vscodebot bot commented Mar 22, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the tasks Task system issues label Mar 22, 2018
@dbaeumer dbaeumer added this to the March 2018 milestone Mar 26, 2018
dbaeumer added a commit that referenced this issue Mar 26, 2018
@dbaeumer
Copy link
Member

Fixed by tweaking the problem matcher

@Tyriar Tyriar added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2018
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants