Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Dynamically update Open in Terminal explorer context menu item based on configuration #99542

Closed
Tyriar opened this issue Jun 6, 2020 · 1 comment · Fixed by #99543
Closed

Dynamically update Open in Terminal explorer context menu item based on configuration #99542

Tyriar opened this issue Jun 6, 2020 · 1 comment · Fixed by #99543
Assignees
@Tyriar
Labels
polish Cleanup and polish issue terminal General terminal issues that don't fall under another label
Milestone
June 2020

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 6, 2020

Currently "Open in Terminal" is part of the core explorer context menu which is not very descriptive as it can be configured to open the external terminal as well. Based on terminal.external.*Exec/terminal.explorerKind we can update the name of the item to these:
@Tyriar Tyriar added polish Cleanup and polish issue terminal General terminal issues that don't fall under another label labels Jun 6, 2020
@Tyriar Tyriar added this to the June 2020 milestone Jun 6, 2020
@Tyriar Tyriar self-assigned this Jun 6, 2020
Tyriar added a commit that referenced this issue Jun 7, 2020
@Tyriar
Simplify open in terminal context menu registration
df4ff4e 
Part of #99542
Tyriar added a commit that referenced this issue Jun 7, 2020
@Tyriar
Set open in terminal menu dynamically
1ea26c5 
Fixes #99542
@Tyriar Tyriar mentioned this issue Jun 7, 2020
Merged
@Tyriar
Copy link
Member Author

Tyriar commented Jun 29, 2020

Verifier: test the context button on Windows 10 with the following settings to test the 3 different supported labels:

  • "terminal.explorerKind": "external"
  • "terminal.external.windowsExec": "wt"

@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@Tyriar Tyriar

Labels
polish Cleanup and polish issue terminal General terminal issues that don't fall under another label
Projects
None yet
Milestone
June 2020
Development

Successfully merging a pull request may close this issue.

Change Open in Terminal context menu title dynamically based on settings microsoft/vscode
1 participant
@Tyriar