Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[typescript-language-features] Expandable hover #228255

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Conversation

gabritto
Copy link
Member

@gabritto gabritto commented Sep 11, 2024

TypeScript counterpart: microsoft/TypeScript#59940

See description of the TS PR for what's currently supported.

mjbvz
mjbvz previously approved these changes Sep 13, 2024
@vs-code-engineering vs-code-engineering bot added this to the September 2024 milestone Sep 13, 2024
amunger
amunger previously approved these changes Sep 13, 2024
@gabritto gabritto marked this pull request as draft September 13, 2024 17:45
@mjbvz
Copy link
Collaborator

mjbvz commented Sep 18, 2024

@gabritto Should we merge this for testing? If you prefer we can gate this behind an experimental setting too

@gabritto
Copy link
Member Author

@gabritto Should we merge this for testing? If you prefer we can gate this behind an experimental setting too

As discussed offline, I'll implement the missing part of detecting when expansion is possible or not (both in this PR and on the TSServer PR), and then we can merge this for testing.

@mjbvz can you point me to how to add a vscode setting to gate this?

@mjbvz
Copy link
Collaborator

mjbvz commented Sep 18, 2024

Thanks @gabritto. For the setting, try taking a look at typescript.autoClosingTags. If the new setting is called typescript.experimental.expandableHover, you can use something like this to check it at turn time:

vscode.workspace.getConfiguration('typescript').get('experimental.expandableHover');

@gabritto gabritto dismissed stale reviews from amunger and mjbvz via ca8d20e September 23, 2024 22:56
@gabritto gabritto marked this pull request as ready for review September 23, 2024 23:00
@mjbvz mjbvz merged commit 0f9abf3 into microsoft:main Sep 24, 2024
7 checks passed
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 8, 2024
@gabritto gabritto deleted the hover branch February 7, 2025 20:21
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants