-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Use async find provider only for file scheme #230592
Conversation
Instead of withdrawing Explorer async find for every scheme other than Perhaps make the setting default in such a way that the new async find provider is on for Ideally you'd be able to detect whether a FileSearchProvider for a given scheme is (a) available, (b) contributed but not yet initialized, or (c) not contributed. But if that's infeasible in time for a recovery release then the setting would suffice, plus it would bring a benefit for discontented |
Can you now use what @andreamah added in #230731? |
Not for the recovery release as it requires more changes which could be risky. If I use it, it will currently only work for file scheme and maybe remote, but not for extensions as the register late. Will think of a fix for insiders |
* only use asyncfindprovider for file scheme * add vscode remote
* only use asyncfindprovider for file scheme * add vscode remote
* only use asyncfindprovider for file scheme * add vscode remote
Use async find provider only for file scheme (#230592) * only use asyncfindprovider for file scheme * add vscode remote
This pull request modifies the ExplorerView to utilize the async find provider exclusively for resources with the 'file' scheme. This change ensures that the find results provider is only instantiated when all roots support the file scheme.
fixes #230483