Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Use async find provider only for file scheme #230592

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

benibenj
Copy link
Contributor

@benibenj benibenj commented Oct 5, 2024

This pull request modifies the ExplorerView to utilize the async find provider exclusively for resources with the 'file' scheme. This change ensures that the find results provider is only instantiated when all roots support the file scheme.

fixes #230483

@benibenj benibenj self-assigned this Oct 5, 2024
@benibenj benibenj enabled auto-merge (squash) October 5, 2024 14:46
@benibenj benibenj disabled auto-merge October 5, 2024 14:47
@gjsjohnmurray
Copy link
Contributor

gjsjohnmurray commented Oct 7, 2024

Instead of withdrawing Explorer async find for every scheme other than file I suggest you consider adding a temporary window-scoped setting allowing users to turn it off. This will provide a solution for users of FileSystemProviders for which there is not yet a FileSearchProvider, and should also placate users working with ordinary files (i.e. file scheme) who are unhappy with the loss of highlight-mode finding (edit: and folder-finding) in Explorer tree.

Perhaps make the setting default in such a way that the new async find provider is on for file scheme and off for all other schemes.

Ideally you'd be able to detect whether a FileSearchProvider for a given scheme is (a) available, (b) contributed but not yet initialized, or (c) not contributed. But if that's infeasible in time for a recovery release then the setting would suffice, plus it would bring a benefit for discontented file-scheme users.

@gjsjohnmurray
Copy link
Contributor

Can you now use what @andreamah added in #230731?

@benibenj
Copy link
Contributor Author

benibenj commented Oct 8, 2024

Not for the recovery release as it requires more changes which could be risky. If I use it, it will currently only work for file scheme and maybe remote, but not for extensions as the register late. Will think of a fix for insiders

@benibenj benibenj enabled auto-merge (squash) October 9, 2024 06:58
@benibenj benibenj merged commit 384ff73 into release/1.94 Oct 9, 2024
7 checks passed
@benibenj benibenj deleted the benibenj/findCandidate branch October 9, 2024 09:20
benibenj added a commit that referenced this pull request Oct 27, 2024
* only use asyncfindprovider for file scheme

* add vscode remote
benibenj added a commit that referenced this pull request Oct 27, 2024
* only use asyncfindprovider for file scheme

* add vscode remote
benibenj added a commit that referenced this pull request Oct 27, 2024
* only use asyncfindprovider for file scheme

* add vscode remote
benibenj added a commit that referenced this pull request Oct 27, 2024
* Use async find provider only for file scheme (#230592)

* only use asyncfindprovider for file scheme

* add vscode remote

* Use async find provider only for file scheme (#230592)

* only use asyncfindprovider for file scheme

* add vscode remote

* 💄
benibenj added a commit that referenced this pull request Oct 28, 2024
Use async find provider only for file scheme (#230592)

* only use asyncfindprovider for file scheme

* add vscode remote
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Nov 23, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants