Adding Emmet preference for changing fuzzySearchMinScore #45240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
reviewed
Mar 8, 2018
extensions/emmet/package.nls.json
Outdated
| @@ -52,5 +52,6 @@ | |||
| "emmetPreferencesCssWebkitProperties": "Comma separated CSS properties that get the 'webkit' vendor prefix when used in Emmet abbreviation that starts with `-`. Set to empty string to always avoid the 'webkit' prefix.", | |||
| "emmetPreferencesCssMozProperties": "Comma separated CSS properties that get the 'moz' vendor prefix when used in Emmet abbreviation that starts with `-`. Set to empty string to always avoid the 'moz' prefix.", | |||
| "emmetPreferencesCssOProperties": "Comma separated CSS properties that get the 'o' vendor prefix when used in Emmet abbreviation that starts with `-`. Set to empty string to always avoid the 'o' prefix.", | |||
| "emmetPreferencesCssMsProperties": "Comma separated CSS properties that get the 'ms' vendor prefix when used in Emmet abbreviation that starts with `-`. Set to empty string to always avoid the 'ms' prefix." | |||
| "emmetPreferencesCssMsProperties": "Comma separated CSS properties that get the 'ms' vendor prefix when used in Emmet abbreviation that starts with `-`. Set to empty string to always avoid the 'ms' prefix.", | |||
| "emmetPreferencesFuzzySearchMinScore": "Number between 0 and 1 defining the minimum score a match should get in order to be shown as suggestion." | |||
There was a problem hiding this comment.
Use the description from https://docs.emmet.io/customization/preferences/ for css.fuzzySearchMinScore
There was a problem hiding this comment.
We should probably prefix this setting with css as it does not apply to html abbreviations
|
Please also update the vscode-emmet-helper version 1.2.1 in the package.json, run yarn to update yarn.lock and include those files in this PR |
ramya-rao-a
approved these changes
Mar 9, 2018
joaomoreno
pushed a commit
that referenced
this pull request
Mar 9, 2018
* Adding Emmet preference for changing fuzzySearchMinScore * Changing name and description of the new setting. * Updating version of vscode-emmet-helper
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been requested in #44568
See also microsoft/vscode-emmet-helper#25
This new preference will define how good should be a match in order to be shown by Emmet. Higher numbers are better matches, so setting this preference to a number closer to 1 should prevent emmet suggestions to appear as often.
Setting it by default to 0.3