Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix #98102 #98127

Merged
merged 1 commit into from
May 19, 2020
Merged

fix #98102 #98127

merged 1 commit into from
May 19, 2020

Conversation

HaoboGu
Copy link
Contributor

@HaoboGu HaoboGu commented May 19, 2020

When VSCode selects preselected completion items, the index shouldn't start from 1. If there are multiple completion items with preselect=true, the first item will never be chosen.

This PR fixes #98102

@HaoboGu
fix #98102
51fe691 
When VSCode selects preselected completion items, the index shouldn't start from 1. If there are multiple completion items with preselect=true, the first item will never be chosen.
@jrieken jrieken added this to the May 2020 milestone May 19, 2020
@jrieken jrieken merged commit 4324517 into microsoft:master May 19, 2020
@jrieken
Copy link
Member

jrieken commented May 19, 2020

Thanks @HaoboGu

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@jrieken jrieken jrieken approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
May 2020
Development

Successfully merging this pull request may close these issues.

VSCode preselects a wrong CompletionItem if there are multiple CompletionItem having preselect=true
2 participants
@HaoboGu @jrieken