Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update Microsoft.Extensions.DependencyModel to 3.1.0 #5188

Merged
merged 6 commits into from
Sep 11, 2024

Conversation

nohwnd
Copy link
Member

@nohwnd nohwnd commented Aug 27, 2024

Update to non-deprecated version that is not bringing new dependencies.

@nohwnd
Copy link
Member Author

nohwnd commented Sep 10, 2024

@MichaelSimons can you please advise on what I am doing wrong? The previous version was okay with source build.

And please remind me what team I should tag here instead of you specifically, the md says to mention team member https://github.com/dotnet/source-build/blob/main/Documentation/sourcebuild-in-repos/new-dependencies.md#adding-dependencies but the team looks to be internal.

Thank you.

@MichaelSimons
Copy link
Member

MichaelSimons commented Sep 10, 2024

@MichaelSimons can you please advise on what I am doing wrong? The previous version was okay with source build.

Because of the Version.Detail.xml dependency, source-build will lift this to the current version. The 3.1.0 version is only reported as a prebuilt in the repo level source-build where lifting does not occur. Because of this, <UsagePattern IdentityGlob="Microsoft.Extensions.DependencyModel/3.1.0*" /> should be added to https://github.com/microsoft/vstest/blob/main/eng/SourceBuildPrebuiltBaseline.xml.

And please remind me what team I should tag here instead of you specifically, the md says to mention team member https://github.com/dotnet/source-build/blob/main/Documentation/sourcebuild-in-repos/new-dependencies.md#adding-dependencies but the team looks to be internal.

https://github.com/orgs/dotnet/teams/source-build-internal is the appropriate team to ping. Apologies, the name is not the best.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants