Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

-version does not allow for a single version value #270

Closed
tydunkel opened this issue Jul 20, 2022 · 2 comments · Fixed by #280
Closed

-version does not allow for a single version value #270

tydunkel opened this issue Jul 20, 2022 · 2 comments · Fixed by #280

Comments

@tydunkel
Copy link
Member

Running vswhere.exe -version 17 doesn't set the version range to be [17,18) but rather uses the max version for the upper bound. It may be less confusing to support a single version value for -version and set the maximum of the range to be the same as the minimum.

@heaths
Copy link
Member

heaths commented Jul 20, 2022

This is the documented behavior and consistent with VSIXInstaller version ranges. A single version means [17,). Not to mention, changing this would be a breaking change for anyone looking for, say, 15+ via -version 15.

@heaths
Copy link
Member

heaths commented Jul 20, 2022

If anything, perhaps we can expand on the version syntax or at least link to https://github.com/microsoft/vswhere/wiki/Examples (maybe add a heading directly for version syntax, or add a new page and link to that from examples).

heaths added a commit to heaths/vswhere that referenced this issue Nov 14, 2022
Fixes microsoft#276. Also resolves microsoft#270 by including link to more details on versioning syntax.
@heaths heaths linked a pull request Nov 14, 2022 that will close this issue
heaths added a commit to heaths/vswhere that referenced this issue Nov 14, 2022
Fixes microsoft#276. Also resolves microsoft#270 by including link to more details on versioning syntax.
heaths added a commit that referenced this issue Nov 15, 2022
* Support DOS-like wildcards in -requires

Fixes #276. Also resolves #270 by including link to more details on versioning syntax.

* Update minor version for new feature
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants