fix: remove use of std in windows-strings h! macro #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This crate can be used in no_std, but some use of std were left in the h! macro. They can be trivially converted to core.
kennykerr
approved these changes
Nov 28, 2024
|
Thanks for the fix! The crates are only published on demand. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This crate can be used in no_std, but some use of std were left in the h! macro. They can be trivially converted to core.
On this subject, i've been using the windows crates in no_std setups, and this is the only issue I reached, the rest seems to work great.
However, the windows 0.58 does not have all the no_std fixes, is there a release planned soon to be able to get those changes?