Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update windows-bindgen to support unsafe_op_in_unsafe_fn #3393

Merged
merged 10 commits into from
Dec 13, 2024

Conversation

kennykerr
Copy link
Collaborator

@kennykerr kennykerr commented Dec 13, 2024

This gets us a long way toward supporting Rust edition 2024. This does require an MSRV bump though. So I've just bumped all my 1.60 crates to 1.74 with the exception of windows-sys which remains on 1.60 for now.

Fixes: #3391

@ChrisDenton
Copy link
Collaborator

Alternatively you do #![deny(unsafe_op_in_unsafe_fn)], which should work for 1.52+. But bumping the MSRV is admittedly simpler 🙂.

@kennykerr
Copy link
Collaborator Author

Thanks, good to know. Unless there's a good reason to stick with an older MSRV I'd rather move things along especially since 1.74 is already over a year old.

@ChrisDenton
Copy link
Collaborator

Very fair!

@kennykerr kennykerr merged commit aca1a34 into master Dec 13, 2024
75 checks passed
@kennykerr kennykerr deleted the unsafe_op_in_unsafe_fn branch December 13, 2024 19:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

windows-bindgen should support Rust edition 2024
2 participants