Fix certain msstore source 404 failures by treating them as empty responses #5179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Does this resolve: which subsequently should be the fix for as well? |
Yes. I'll link the issues. Thanks! |
microsoft-github-policy-service
bot
added
Issue-Bug
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JohnMcPMS
approved these changes
Feb 4, 2025
There was a problem hiding this comment.
Reminder to also cherry-pick to https://github.com/microsoft/winget-cli/tree/release-v1.10
JohnMcPMS
pushed a commit
that referenced
this pull request
Feb 5, 2025
…ponses (#5179) When searching for store source with id that's recently taken down, store source will return 404 instead of empty results (what winget-cli-restsource does). This will be treated as a source search error in our code. The fix is to treat 404 response with certain schema as empty result instead of failure. Tested manually with store source and added unit tests. fixes #4785, fixes #4784
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When searching for store source with id that's recently taken down, store source will return 404 instead of empty results (what winget-cli-restsource does). This will be treated as a source search error in our code. The fix is to treat 404 response with certain schema as empty result instead of failure.
Tested manually with store source and added unit tests.
fixes #4785, fixes #4784
Microsoft Reviewers: Open in CodeFlow