Support auto-fetching metadata from GitHub API and add manual args #543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdanish-kh
requested review from
yao-msft and
ryfu-msft
and removed request for
a team
mdanish-kh
commented
Aug 5, 2024
src/WingetCreateTests/WingetCreateTests/UnitTests/GitHubTests.cs
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
the
Issue-Feature
vedantmgoyal9
suggested changes
Aug 5, 2024
|
@mdanish-kh please add reference to these issues too: |
|
@vedantmgoyal9 I feel the issues mentioned and their proposed implementations by the authors are not 'directly' addressed by this PR. If this gets merged, we can have a convo with the authors to check if this implementation caters their request |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
requested changes
Aug 6, 2024
...ources/Multifile.Json.GitHubAutoFillTest/Multifile.Json.GitHubAutoFillTest.locale.en-US.json
Outdated
Show resolved
Hide resolved
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
and removed
Needs-Author-Feedback
labels
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ryfu-msft
approved these changes
Aug 6, 2024
This was referenced Aug 7, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for auto-populating metadata from GitHub API. Also adds two new args
--release-notes-urland--release-datefor explicitly specifying the metadata. These args take precedence over any auto-populated valuesWe only hit the GitHub API if we have a valid GitHub token specified. There's an issue with serializing
ReleaseDatewith our yaml serializer, so we updateReleaseDateTimefor that instead.Microsoft Reviewers: Open in CodeFlow