Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

New version: version-fox.vfox version 0.5.4 #161354

Merged

Conversation

koppor
Copy link
Contributor

@koppor koppor commented Jul 3, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jul 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Retry-1 flag to indicate retried label Jul 3, 2024
@koppor
Copy link
Contributor Author

koppor commented Jul 3, 2024

I don't know, what the failed output means:


7/3/2024 3:16:35 PM

****************************************************************************************
Installation Verification
****************************************************************************************
Status: Started
============================================================================== 
Task         : Installation Validation
Description  : Invoke an Azure Function
Version      : 1.220.0
Author       : Microsoft Corporation
Help URL     : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/azure-function
============================================================================== 
2024-07-03T15:16:36.0927983Z POST ***?code=***&
Request body: {
  "operationId": "WinGetSvc-Validation-391-161354-20240703-1",
  "BuildId": "590872",
  "PlanUrl": "https://dev.azure.com/ms/",
  "HubName": "build",
  "ProjectId": "ed6a5dfa-6e7f-413b-842c-8305dd9e89e6",
  "PlanId": "65160bff-c08e-47b9-b29e-67e332de7b54",
  "JobId": "68997d86-8ece-5ae8-3ac5-ccdbfa458731",
  "TimelineId": "65160bff-c08e-47b9-b29e-67e332de7b54",
  "TaskInstanceId": "b79910ce-dca5-5e27-ad7f-bd285eecb5a2",
  "AuthToken": ***
}
				Response Code: OK
				Response: 

7/3/2024 3:48:30 PM

****************************************************************************************
Installation Verification
****************************************************************************************

-----------------------------------------------------
Result: Failed
-----------------------------------------------------
Status: Completed

Is it because the installier is not signed?

@koppor
Copy link
Contributor Author

koppor commented Jul 4, 2024

I needed to edit the files manually - details written down at microsoft/winget-create#466 (comment).

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 4, 2024
@wingetbot wingetbot added the Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. label Jul 4, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 4, 2024
@hackean-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Internal-Error-Dynamic-Scan The test for Dynamic Scanning in the Installation Validation failed. Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 7, 2024
@hackean-msft
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Manifest Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 7, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) July 7, 2024 16:32
@stephengillie
Copy link
Collaborator

I needed to edit the files manually - details written down at microsoft/winget-create#466 (comment).

Sorry to hear, but everything appears to be valid. Also sorry that you got caught up in our pipeline issues.

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 976d85c into microsoft:master Jul 8, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label Jul 8, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR New-Manifest Publish-Pipeline-Succeeded Retry-1 flag to indicate retried Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants