industry dora scores enums #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayantbh
approved these changes
Aug 6, 2024
e-for-eshaan
reviewed
Aug 6, 2024
| @@ -6,6 +6,23 @@ import { | |||
| } from 'date-fns/constants'; | |||
| import { isNil, mean, reject } from 'ramda'; | |||
|
|
|||
| export enum IndustryStandardsDoraScores { | |||
There was a problem hiding this comment.
there should be an enum of all values like:
export enum Industries = {
ALL_INDUSTRIES = "ALL_INDUSTRIES"
...
}
and then a map like
IndustryStandardsDoraScores = {
[Industries.ALL_INDUSTRIES] : 6.3,
...
}
that way we can easily iterate over this entire set
There was a problem hiding this comment.
Great idea.
Addressed this in #499
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Added an enum for industry standard scores for
Dora Metrics. We will later use this in the UI to display different standard scores based on the industry.Further comments