-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Default sync days setting #501
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r sync days instead of getting the value from the environment variable. Default sync days is set to be 31
…C_DAYS variable from there
This will be changed later once the functionalities depending on this service reading the default sync days from envs are changed
samad-yar-khan
requested changes
Aug 7, 2024
@@ -54,9 +59,19 @@ def sync_org_incident_services(self, org_id: str): | |||
LOG.error(f"Error syncing incident services for org {org_id}: {str(e)}") | |||
return | |||
|
|||
def _sync_service_incidents(self, service: OrgIncidentService): | |||
def _sync_service_incidents(self, org_id: str, service: OrgIncidentService): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we use service.org_id
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah good point. Thanks
samad-yar-khan
approved these changes
Aug 7, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
DEFAULT_SNC_DAYS_SETTINGS
part of the settings module.31
is used.get_settings
function from the settings serviceTesting
DEFAULT_SYNC_DAYS_SETTING
:Further comments