Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed unused setting should_sync_alerts_as_incidents #531

Merged

Conversation

Kamlesh72
Copy link
Contributor

Linked Issue(s)

Closes #521

Acceptance Criteria fulfillment

  • Removed usages of setting with key should_sync_alerts_as_incidents

Copy link
Contributor

@samad-yar-khan samad-yar-khan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @Kamlesh72 !

@samad-yar-khan samad-yar-khan merged commit 9d5d161 into middlewarehq:main Sep 1, 2024
1 check passed
@jayantbh
Copy link
Contributor

jayantbh commented Sep 1, 2024

Best PR I've seen in a while. ❤️

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused setting should_sync_alerts_as_incidents
3 participants