fix(swagger): fix the parsing of enum types with array (#4078) #4098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4098 +/- ##
==========================================
+ Coverage 84.55% 85.13% +0.58%
==========================================
Files 491 514 +23
Lines 46778 49123 +2345
Branches 5601 5199 -402
==========================================
+ Hits 39551 41823 +2272
- Misses 7191 7271 +80
+ Partials 36 29 -7 ☔ View full report in Codecov by Sentry. |
czy88840616
reviewed
Sep 29, 2024
packages/swagger/test/parser.test.ts
Outdated
| isArray: true, | ||
| }); | ||
|
|
||
| expect(result).toEqual({ |
There was a problem hiding this comment.
这好像不是这么用的
{
type: 'array',
items: {
type: 'enum',
enum: Animal
},
}There was a problem hiding this comment.
原来我一开始理解对了 🤣
但我后面细看了下你引用的代码块，以为你在说单测的问题，单测也确实有问题
added 2 commits
September 29, 2024 18:05
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpassesAffected core subsystem(s)
@midway/swagger
Description of change
#4078