Reorganize to v2 addon format #678
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The first step in porting to v2 is to separate the addon code from the test-app code. I've followed the standard of building a monorepo with the addon code in `packages/ember-leaflet` and the (eventual) test-app in `packages/test-app`. Additionally, the republishing code in `app/` is no longer necessary. Finally, I've moved the addon's package.json into the addon space, where it will be pared down.
The old dummy app is a new packages, in `packages/docs`. The test app is exclusively for use with testing. All of the tests have been moved into the test app's workspace.
Ember-related files have been deleted or moved into the addon's space.
…test error As discussed [on discord](https://discord.com/channels/480462759797063690/973199754446131223/981925562769625150), I've run into a problem with the various ember-leaflet components' looking for htmlbars and not finding it. Even though I should not technically have to include it as a dependency in the addon, the tests crash because of it. Additionally, the tests crash because of importing the components from the addon and not the test-app, but I'll get to that problem later.
Now the test-app does not even build, complaining about being unable to resolve ember-cli-htmlbars in the addon.
|
Hi! Thank you for your PR. Is it not done yet? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.